Browse Source

Sharing dialog: fix spotbugs

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
Álvaro Brey Vilas 3 years ago
parent
commit
dc5756246a

+ 1 - 1
src/main/java/com/owncloud/android/ui/fragment/FileDetailSharingFragment.java

@@ -186,7 +186,7 @@ public class FileDetailSharingFragment extends Fragment implements ShareeListAda
         try {
             onEditShareListener = (OnEditShareListener) context;
         } catch (Exception ignored) {
-            throw new IllegalArgumentException("Calling activity must implement the interface");
+            throw new IllegalArgumentException("Calling activity must implement the interface", ignored);
         }
     }
 

+ 2 - 1
src/main/java/com/owncloud/android/ui/fragment/QuickSharingPermissionsBottomSheetDialog.java

@@ -131,7 +131,6 @@ public class QuickSharingPermissionsBottomSheetDialog extends BottomSheetDialog
      * @return
      */
     private List<QuickPermissionModel> getQuickPermissionList() {
-        List<QuickPermissionModel> quickPermissionModelList = new ArrayList<>();
 
         String[] permissionArray;
         if (ocShare.isFolder()) {
@@ -144,6 +143,8 @@ public class QuickSharingPermissionsBottomSheetDialog extends BottomSheetDialog
         //get the checked item position
         int checkedItem = SharingMenuHelper.getPermissionCheckedItem(fileActivity, ocShare, permissionArray);
 
+
+        final List<QuickPermissionModel> quickPermissionModelList = new ArrayList<>(permissionArray.length);
         for (int i = 0; i < permissionArray.length; i++) {
             QuickPermissionModel quickPermissionModel = new QuickPermissionModel(permissionArray[i], checkedItem == i);
             quickPermissionModelList.add(quickPermissionModel);