Kaynağa Gözat

Reduce number of exit points

The method `onReceivedHttpError` did have 3 exit points (`return`), but Codacy only allows us 2, so error handling for `request?.url` and `view?.context` was combined. Seems debatable, what's more readable, but the rules are the rules.

Signed-off-by: Elv1zz <elv1zz.git@gmail.com>
Elv1zz 2 yıl önce
ebeveyn
işleme
e2dd29052b

+ 6 - 3
app/src/main/java/com/owncloud/android/ui/NextcloudWebViewClient.kt

@@ -108,10 +108,13 @@ open class NextcloudWebViewClient(val supportFragmentManager: FragmentManager) :
     ) {
         val errorCode = errorResponse?.statusCode ?: return
         if (errorCode == HttpStatus.SC_BAD_REQUEST) {
-            Log_OC.w(tag, "WebView failed with error code $errorCode; remove key chain aliases")
             // chosen client certificate alias does not seem to work -> discard it
-            val failingUrl = request?.url ?: return
-            val context = view?.context ?: return
+            val failingUrl = request?.url
+            val context = view?.context
+            if (failingUrl == null || context == null) {
+                return
+            }
+            Log_OC.w(tag, "WebView failed with error code $errorCode; remove key chain aliases")
             AdvancedX509KeyManager(context).removeKeys(failingUrl)
         }
     }