Browse Source

codacy: remove unused code/imports

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Andy Scherzinger 4 years ago
parent
commit
eaeb0f350c

+ 0 - 5
src/main/java/com/owncloud/android/ui/adapter/TemplateAdapter.java

@@ -29,14 +29,11 @@ import android.graphics.drawable.Drawable;
 import android.view.LayoutInflater;
 import android.view.LayoutInflater;
 import android.view.View;
 import android.view.View;
 import android.view.ViewGroup;
 import android.view.ViewGroup;
-import android.widget.ImageView;
-import android.widget.TextView;
 
 
 import com.bumptech.glide.Glide;
 import com.bumptech.glide.Glide;
 import com.nextcloud.client.account.CurrentAccountProvider;
 import com.nextcloud.client.account.CurrentAccountProvider;
 import com.nextcloud.client.network.ClientFactory;
 import com.nextcloud.client.network.ClientFactory;
 import com.owncloud.android.R;
 import com.owncloud.android.R;
-import com.owncloud.android.databinding.SendButtonBinding;
 import com.owncloud.android.databinding.TemplateButtonBinding;
 import com.owncloud.android.databinding.TemplateButtonBinding;
 import com.owncloud.android.lib.common.Template;
 import com.owncloud.android.lib.common.Template;
 import com.owncloud.android.lib.common.TemplateList;
 import com.owncloud.android.lib.common.TemplateList;
@@ -46,8 +43,6 @@ import com.owncloud.android.utils.glide.CustomGlideStreamLoader;
 
 
 import androidx.annotation.NonNull;
 import androidx.annotation.NonNull;
 import androidx.recyclerview.widget.RecyclerView;
 import androidx.recyclerview.widget.RecyclerView;
-import butterknife.BindView;
-import butterknife.ButterKnife;
 
 
 /**
 /**
  * Adapter for handling Templates, used to create files out of it via RichDocuments app
  * Adapter for handling Templates, used to create files out of it via RichDocuments app

+ 6 - 6
src/main/java/com/owncloud/android/ui/dialog/ChooseRichDocumentsTemplateDialogFragment.java

@@ -138,6 +138,12 @@ public class ChooseRichDocumentsTemplateDialogFragment extends DialogFragment im
             throw new IllegalArgumentException("Activity may not be null");
             throw new IllegalArgumentException("Activity may not be null");
         }
         }
 
 
+        try {
+            client = clientFactory.create(currentAccount.getUser());
+        } catch (ClientFactory.CreationException e) {
+            throw new RuntimeException(e); // we'll NPE without the client
+        }
+
         parentFolder = arguments.getParcelable(ARG_PARENT_FOLDER);
         parentFolder = arguments.getParcelable(ARG_PARENT_FOLDER);
 
 
         // Inflate the layout for the dialog
         // Inflate the layout for the dialog
@@ -148,12 +154,6 @@ public class ChooseRichDocumentsTemplateDialogFragment extends DialogFragment im
         binding.filename.requestFocus();
         binding.filename.requestFocus();
         ThemeUtils.colorTextInput(binding.filenameContainer, binding.filename, ThemeUtils.primaryColor(getContext()));
         ThemeUtils.colorTextInput(binding.filenameContainer, binding.filename, ThemeUtils.primaryColor(getContext()));
 
 
-        try {
-            client = clientFactory.create(currentAccount.getUser());
-        } catch (ClientFactory.CreationException e) {
-            throw new RuntimeException(e); // we'll NPE without the client
-        }
-
         Type type = Type.valueOf(arguments.getString(ARG_TYPE));
         Type type = Type.valueOf(arguments.getString(ARG_TYPE));
         new FetchTemplateTask(this, client).execute(type);
         new FetchTemplateTask(this, client).execute(type);
 
 

+ 2 - 4
src/main/java/com/owncloud/android/ui/dialog/ChooseTemplateDialogFragment.java

@@ -30,7 +30,6 @@ import android.content.Context;
 import android.content.Intent;
 import android.content.Intent;
 import android.os.AsyncTask;
 import android.os.AsyncTask;
 import android.os.Bundle;
 import android.os.Bundle;
-import android.os.Parcelable;
 import android.text.Editable;
 import android.text.Editable;
 import android.text.TextWatcher;
 import android.text.TextWatcher;
 import android.view.LayoutInflater;
 import android.view.LayoutInflater;
@@ -65,8 +64,6 @@ import com.owncloud.android.utils.DisplayUtils;
 import com.owncloud.android.utils.FileStorageUtils;
 import com.owncloud.android.utils.FileStorageUtils;
 import com.owncloud.android.utils.ThemeUtils;
 import com.owncloud.android.utils.ThemeUtils;
 
 
-import org.jetbrains.annotations.NotNull;
-
 import java.lang.ref.WeakReference;
 import java.lang.ref.WeakReference;
 
 
 import javax.inject.Inject;
 import javax.inject.Inject;
@@ -87,6 +84,7 @@ public class ChooseTemplateDialogFragment extends DialogFragment implements View
     private static final String ARG_HEADLINE = "HEADLINE";
     private static final String ARG_HEADLINE = "HEADLINE";
     private static final String TAG = ChooseTemplateDialogFragment.class.getSimpleName();
     private static final String TAG = ChooseTemplateDialogFragment.class.getSimpleName();
     private static final String DOT = ".";
     private static final String DOT = ".";
+    public static final int SINGLE_TEMPLATE = 1;
 
 
     private TemplateAdapter adapter;
     private TemplateAdapter adapter;
     private OCFile parentFolder;
     private OCFile parentFolder;
@@ -418,7 +416,7 @@ public class ChooseTemplateDialogFragment extends DialogFragment implements View
                 if (templateList.templates.isEmpty()) {
                 if (templateList.templates.isEmpty()) {
                     DisplayUtils.showSnackMessage(fragment.binding.list, R.string.error_retrieving_templates);
                     DisplayUtils.showSnackMessage(fragment.binding.list, R.string.error_retrieving_templates);
                 } else {
                 } else {
-                    if (templateList.templates.size() == 1) {
+                    if (templateList.templates.size() == SINGLE_TEMPLATE) {
                         fragment.onTemplateChosen(templateList.templates.values().iterator().next());
                         fragment.onTemplateChosen(templateList.templates.values().iterator().next());
                         fragment.binding.list.setVisibility(View.GONE);
                         fragment.binding.list.setVisibility(View.GONE);
                     } else {
                     } else {

+ 0 - 1
src/main/java/com/owncloud/android/utils/ThemeUtils.java

@@ -45,7 +45,6 @@ import android.widget.ImageView;
 import android.widget.ProgressBar;
 import android.widget.ProgressBar;
 import android.widget.SeekBar;
 import android.widget.SeekBar;
 
 
-import com.google.android.material.button.MaterialButton;
 import com.google.android.material.floatingactionbutton.FloatingActionButton;
 import com.google.android.material.floatingactionbutton.FloatingActionButton;
 import com.google.android.material.snackbar.Snackbar;
 import com.google.android.material.snackbar.Snackbar;
 import com.google.android.material.tabs.TabLayout;
 import com.google.android.material.tabs.TabLayout;