Fix magic numbers in grid_item.xml #12

res/layout/grid_item.xml

@@ -35,15 +35,15 @@
             android:layout_width="@dimen/standard_list_item_size"
             android:layout_height="@dimen/standard_list_item_size"
             android:layout_gravity="center_horizontal"
-            android:layout_marginLeft="10dp"
-            android:layout_marginRight="10dp"
+            android:layout_marginLeft="@dimen/fragment_margin"
+            android:layout_marginRight="@dimen/alternate_margin"
             android:src="@drawable/ic_menu_archive" />
 
         <ImageView
             android:id="@+id/sharedIcon"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
-            android:layout_margin="4dp"
+            android:layout_margin="@dimen/standard_quarter_margin"
             android:layout_gravity="top|right"
             android:src="@drawable/shared_via_link" />
 
@@ -52,17 +52,17 @@
             android:layout_width="@dimen/file_icon_size"
             android:layout_height="@dimen/file_icon_size"
             android:layout_gravity="bottom|right"
-            android:layout_marginTop="2dp"
-            android:layout_marginRight="2dp"
+            android:layout_marginTop="@dimen/standard_eighth_margin"
+            android:layout_marginRight="@dimen/standard_eighth_margin"
             android:src="@drawable/ic_synced" />
 
         <ImageView
             android:id="@+id/favoriteIcon"
-            android:layout_width="15dp"
-            android:layout_height="15dp"
+            android:layout_width="@dimen/favorite_icon_size"
+            android:layout_height="@dimen/favorite_icon_size"
             android:layout_gravity="bottom|right"
-            android:layout_marginBottom="2dp"
-            android:layout_marginRight="2dp"
+            android:layout_marginBottom="@dimen/standard_eighth_margin"
+            android:layout_marginRight="@dimen/standard_eighth_margin"
             android:src="@drawable/ic_available_offline" />
 
         <ImageView
@@ -70,10 +70,10 @@
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
             android:layout_gravity="center_vertical|top"
-            android:layout_marginLeft="4dp"
-            android:layout_marginRight="4dp"
+            android:layout_marginLeft="@dimen/standard_quarter_margin"
+            android:layout_marginRight="@dimen/standard_quarter_margin"
             android:src="@android:drawable/checkbox_off_background"
-            android:elevation="30dp" />
+            android:elevation="@dimen/elevation" />
 
     </FrameLayout>
 
@@ -81,13 +81,13 @@
         android:id="@+id/Filename"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
-        android:layout_marginLeft="4dp"
-        android:layout_marginRight="4dp"
+        android:layout_marginLeft="@dimen/standard_quarter_margin"
+        android:layout_marginRight="@dimen/standard_quarter_margin"
         android:ellipsize="middle"
         android:gravity="center_horizontal"
         android:singleLine="true"
         android:text="TextView"
         android:textColor="@color/textColor"
-        android:textSize="16dip" />
+        android:textSize="@dimen/grid_item_text_size" />
 
 </com.owncloud.android.ui.SquareLinearLayout>

res/values/dims.xml

@@ -41,6 +41,7 @@
     <dimen name="standard_margin">16dp</dimen>
     <dimen name="standard_half_margin">8dp</dimen>
     <dimen name="standard_quarter_margin">4dp</dimen>
+    <dimen name="standard_eighth_margin">2dp</dimen>
     <dimen name="min_list_item_size">56dp</dimen>
     <dimen name="standard_list_item_size">72dp</dimen>
 
@@ -90,4 +91,6 @@
     <dimen name="files_drawer_width">240dp</dimen>
 
     <dimen name="favorite_icon_size">15dp</dimen>
+    <dimen name="elevation">30dp</dimen>
+    <dimen name="grid_item_text_size">16dip</dimen>
 </resources>