Browse Source

Fix magic numbers in uploader_list_item_layout.xml #12

Divay Prakash 8 years ago
parent
commit
f48b0b074d
2 changed files with 9 additions and 7 deletions
  1. 7 7
      res/layout/uploader_list_item_layout.xml
  2. 2 0
      res/values/dims.xml

+ 7 - 7
res/layout/uploader_list_item_layout.xml

@@ -28,11 +28,11 @@
         android:layout_width="@dimen/file_icon_size"
         android:layout_height="@dimen/file_icon_size"
         android:layout_gravity="center_vertical"
-        android:layout_margin="12dp"
+        android:layout_margin="@dimen/uploader_list_item_layout_image_margin"
         android:src="@drawable/ic_menu_archive" />
 
     <LinearLayout
-        android:layout_width="0dp"
+        android:layout_width="@dimen/zero"
         android:layout_height="@dimen/standard_list_item_size"
         android:layout_weight="1"
         android:gravity="center_vertical"
@@ -43,19 +43,19 @@
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
             android:layout_gravity="center_vertical"
-            android:layout_marginLeft="0dp"
-            android:layout_marginRight="4dp"
+            android:layout_marginLeft="@dimen/zero"
+            android:layout_marginRight="@dimen/standard_quarter_margin"
             android:ellipsize="middle"
             android:singleLine="true"
             android:text="TextView"
             android:textColor="@color/textColor"
-            android:textSize="16dip" />
+            android:textSize="@dimen/two_line_primary_text_size" />
 
         <LinearLayout
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
-            android:layout_marginLeft="0dp"
-            android:layout_marginRight="4dp"
+            android:layout_marginLeft="@dimen/zero"
+            android:layout_marginRight="@dimen/standard_quarter_margin"
             android:orientation="horizontal">
 
             <TextView

+ 2 - 0
res/values/dims.xml

@@ -127,4 +127,6 @@
     <dimen name="upload_list_item_text_size">12sp</dimen>
     <dimen name="upload_list_item_text_size_independent">12dip</dimen>
     <dimen name="upload_list_item_image_size">35dp</dimen>
+
+    <dimen name="uploader_list_item_layout_image_margin">12dp</dimen>
 </resources>