소스 검색

Fix NPE in UserAccountManagerImpl.getUser(CharSequence)

Optional.of() called on nullable value causes NPE.
We should use Optional.ofNullable() instead, as the
argument can be null by design.

Fixes #5155

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
Chris Narkiewicz 5 년 전
부모
커밋
fe404f0e25
1개의 변경된 파일1개의 추가작업 그리고 1개의 파일을 삭제
  1. 1 1
      src/main/java/com/nextcloud/client/account/UserAccountManagerImpl.java

+ 1 - 1
src/main/java/com/nextcloud/client/account/UserAccountManagerImpl.java

@@ -227,7 +227,7 @@ public class UserAccountManagerImpl implements UserAccountManager {
     public Optional<User> getUser(CharSequence accountName) {
         Account account = getAccountByName(accountName.toString());
         User user =  createUserFromAccount(account);
-        return Optional.of(user);
+        return Optional.ofNullable(user);
     }
 
     @Override