fix code

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

iOSClient/Utility/NCUtility.swift

@@ -437,10 +437,11 @@ class NCUtility: NSObject {
         let metadata = tableMetadata.init(value: metadata)
         let chunckSize = CCUtility.getChunkSize() * 1000000
         var compatibilityFormat: Bool = false
+        var returnWithError: Bool = true
 
-        func callCompletion(error: Bool) {
-            if error {
-                completion(nil, nil, true)
+        defer {
+            if returnWithError {
+                completion(nil, nil, returnWithError)
             } else {
                 var metadataReturn = metadata
                 if modifyMetadataForUpload {
@@ -451,14 +452,12 @@ class NCUtility: NSObject {
                         metadataReturn = metadata
                     }
                 }
-                completion(metadataReturn, fileNamePath, error)
+                completion(metadataReturn, fileNamePath, returnWithError)
             }
         }
 
         let fetchAssets = PHAsset.fetchAssets(withLocalIdentifiers: [metadata.assetLocalIdentifier], options: nil)
-        guard fetchAssets.count > 0, let asset = fetchAssets.firstObject, let extensionAsset = (asset.value(forKey: "filename") as? NSString)?.pathExtension.uppercased() else {
-            return callCompletion(error: true)
-        }
+        guard fetchAssets.count > 0, let asset = fetchAssets.firstObject, let extensionAsset = (asset.value(forKey: "filename") as? NSString)?.pathExtension.uppercased() else { return }
 
         let creationDate = asset.creationDate ?? Date()
         let modificationDate = asset.modificationDate ?? Date()
@@ -477,9 +476,7 @@ class NCUtility: NSObject {
             fileNamePath = NSTemporaryDirectory() + metadata.fileNameView
         }
 
-        guard let fileNamePath = fileNamePath else {
-            return callCompletion(error: true)
-        }
+        guard let fileNamePath = fileNamePath else { return }
 
         if asset.mediaType == PHAssetMediaType.image {
 
@@ -496,25 +493,23 @@ class NCUtility: NSObject {
             }
             options.progressHandler = { (progress, error, stop, info) in
                 print(progress)
-                if error != nil { return callCompletion(error: true) }
+                if error != nil { return }
             }
 
             PHImageManager.default().requestImageDataAndOrientation(for: asset, options: options) { data, dataUI, orientation, info in
-                guard var data = data else { return callCompletion(error: true) }
+                guard var data = data else { return }
                 if compatibilityFormat {
-                    guard let ciImage = CIImage.init(data: data), let colorSpace = ciImage.colorSpace, let dataJPEG = CIContext().jpegRepresentation(of: ciImage, colorSpace: colorSpace) else { return callCompletion(error: true) }
+                    guard let ciImage = CIImage.init(data: data), let colorSpace = ciImage.colorSpace, let dataJPEG = CIContext().jpegRepresentation(of: ciImage, colorSpace: colorSpace) else { return }
                     data = dataJPEG
                 }
                 NCUtilityFileSystem.shared.deleteFile(filePath: fileNamePath)
                 do {
                     try data.write(to: URL(fileURLWithPath: fileNamePath), options: .atomic)
-                } catch {
-                    return callCompletion(error: true)
-                }
+                } catch { return }
                 metadata.creationDate = creationDate as NSDate
                 metadata.date = modificationDate as NSDate
                 metadata.size = NCUtilityFileSystem.shared.getFileSize(filePath: fileNamePath)
-                return callCompletion(error: false)
+                return returnWithError = false
             }
 
         } else if asset.mediaType == PHAssetMediaType.video {
@@ -524,7 +519,7 @@ class NCUtility: NSObject {
             options.version = PHVideoRequestOptionsVersion.current
             options.progressHandler = { (progress, error, stop, info) in
                 print(progress)
-                if error != nil { return callCompletion(error: true) }
+                if error != nil { return }
             }
 
             PHImageManager.default().requestAVAsset(forVideo: asset, options: options) { asset, audioMix, info in
@@ -535,10 +530,8 @@ class NCUtility: NSObject {
                         metadata.creationDate = creationDate as NSDate
                         metadata.date = modificationDate as NSDate
                         metadata.size = NCUtilityFileSystem.shared.getFileSize(filePath: fileNamePath)
-                        return callCompletion(error: false)
-                    } catch {
-                        return callCompletion(error: true)
-                    }
+                        return returnWithError = false
+                    } catch { return }
                 } else if let asset = asset as? AVComposition, asset.tracks.count > 1, let exporter = AVAssetExportSession(asset: asset, presetName: AVAssetExportPresetHighestQuality) {
                     if let viewController = viewController {
                         DispatchQueue.main.async {
@@ -562,20 +555,14 @@ class NCUtility: NSObject {
                             metadata.creationDate = creationDate as NSDate
                             metadata.date = modificationDate as NSDate
                             metadata.size = NCUtilityFileSystem.shared.getFileSize(filePath: fileNamePath)
-                            return callCompletion(error: false)
-                        } else {
-                            return callCompletion(error: true)
-                        }
+                            return returnWithError = false
+                        } else { return }
                     }
                     while exporter.status == AVAssetExportSession.Status.exporting || exporter.status == AVAssetExportSession.Status.waiting {
                         hud.progress = exporter.progress
                     }
-                } else {
-                    return callCompletion(error: true)
                 }
             }
-        } else {
-            return callCompletion(error: true)
         }
     }