فهرست منبع

rename "runAllThings"

:D :D
setUpAfterConversationIsKnown might not be the best name, but i'm not sure when in onCreate the currentConversation can be null. depending on that it might even not be necessary to have the "things" in a method..

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Marcel Hibbe 3 سال پیش
والد
کامیت
7e68ecbde9
1فایلهای تغییر یافته به همراه3 افزوده شده و 3 حذف شده
  1. 3 3
      app/src/main/java/com/nextcloud/talk/activities/CallNotificationActivity.java

+ 3 - 3
app/src/main/java/com/nextcloud/talk/activities/CallNotificationActivity.java

@@ -142,7 +142,7 @@ public class CallNotificationActivity extends BaseActivity {
         if (currentConversation == null) {
             handleFromNotification();
         } else {
-            runAllThings();
+            setUpAfterConversationIsKnown();
         }
 
         if (DoNotDisturbUtils.INSTANCE.shouldPlaySound()) {
@@ -278,7 +278,7 @@ public class CallNotificationActivity extends BaseActivity {
                     @Override
                     public void onNext(@io.reactivex.annotations.NonNull RoomOverall roomOverall) {
                         currentConversation = roomOverall.getOcs().data;
-                        runAllThings();
+                        setUpAfterConversationIsKnown();
 
                         if (apiVersion >= 3) {
                             boolean hasCallFlags =
@@ -316,7 +316,7 @@ public class CallNotificationActivity extends BaseActivity {
                 || Participant.ParticipantFlags.IN_CALL_WITH_AUDIO_AND_VIDEO.getValue() == callFlag);
     }
 
-    private void runAllThings() {
+    private void setUpAfterConversationIsKnown() {
         binding.conversationNameTextView.setText(currentConversation.getDisplayName());
 
         // TODO: load avatar, but don't block UI!