Browse Source

rename "runAllThings"

:D :D
setUpAfterConversationIsKnown might not be the best name, but i'm not sure when in onCreate the currentConversation can be null. depending on that it might even not be necessary to have the "things" in a method..

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Marcel Hibbe 3 years ago
parent
commit
7e68ecbde9

+ 3 - 3
app/src/main/java/com/nextcloud/talk/activities/CallNotificationActivity.java

@@ -142,7 +142,7 @@ public class CallNotificationActivity extends BaseActivity {
         if (currentConversation == null) {
         if (currentConversation == null) {
             handleFromNotification();
             handleFromNotification();
         } else {
         } else {
-            runAllThings();
+            setUpAfterConversationIsKnown();
         }
         }
 
 
         if (DoNotDisturbUtils.INSTANCE.shouldPlaySound()) {
         if (DoNotDisturbUtils.INSTANCE.shouldPlaySound()) {
@@ -278,7 +278,7 @@ public class CallNotificationActivity extends BaseActivity {
                     @Override
                     @Override
                     public void onNext(@io.reactivex.annotations.NonNull RoomOverall roomOverall) {
                     public void onNext(@io.reactivex.annotations.NonNull RoomOverall roomOverall) {
                         currentConversation = roomOverall.getOcs().data;
                         currentConversation = roomOverall.getOcs().data;
-                        runAllThings();
+                        setUpAfterConversationIsKnown();
 
 
                         if (apiVersion >= 3) {
                         if (apiVersion >= 3) {
                             boolean hasCallFlags =
                             boolean hasCallFlags =
@@ -316,7 +316,7 @@ public class CallNotificationActivity extends BaseActivity {
                 || Participant.ParticipantFlags.IN_CALL_WITH_AUDIO_AND_VIDEO.getValue() == callFlag);
                 || Participant.ParticipantFlags.IN_CALL_WITH_AUDIO_AND_VIDEO.getValue() == callFlag);
     }
     }
 
 
-    private void runAllThings() {
+    private void setUpAfterConversationIsKnown() {
         binding.conversationNameTextView.setText(currentConversation.getDisplayName());
         binding.conversationNameTextView.setText(currentConversation.getDisplayName());
 
 
         // TODO: load avatar, but don't block UI!
         // TODO: load avatar, but don't block UI!